This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
closes #398 - "Previous/Next Surah" when reading first/last surah #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32831 |
| @@ -0,0 +1,62 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import { shallow, render } from 'enzyme'; | |||
There was a problem hiding this comment.
i dont think you are using render
|
woot! This is awesome mashallah :) |
|
fixes have been pushed. |
|
Deployed to: http://staging.quran.com:32832 |
| @@ -3,11 +3,11 @@ | |||
| "version": "1.0.0", | |||
| "private": false, | |||
| "scripts": { | |||
| "test": "./node_modules/karma/bin/karma start", | |||
There was a problem hiding this comment.
just an FYI, npm makes anything within node_modules/.bin usable as a global within npm scripts.
|
Deployed to: http://staging.quran.com:32839 |
|
can we get this merged in? |
|
Deployed to: http://staging.quran.com:32840 |
|
Deployed to: http://staging.quran.com:32842 |
|
merged based on your previous comment @mmahalwy |
|
Why this doesn't show in quran.com ? |
|
@srifqi I don't think there was a production release. https://github.com/quran/quran.com-frontend/commits/production |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed + unit tests
closes #398